Skip to content

Conversation

@Acly
Copy link
Collaborator

@Acly Acly commented Oct 31, 2025

Add support for ggml_interpolate with GGML_SCALE_MODE_BICUBIC in CPU backend. Spline parameters are chosen to match PyTorch results.

Will add Vulkan implementation in a follow-up PR.

@Acly Acly requested review from ggerganov and slaren as code owners October 31, 2025 09:39
@github-actions github-actions bot added the ggml changes relating to the ggml tensor library for machine learning label Oct 31, 2025
@CISC
Copy link
Collaborator

CISC commented Nov 4, 2025

@Acly Need someone to merge?

@Acly
Copy link
Collaborator Author

Acly commented Nov 4, 2025

@CISC Yes, I don't think I can do it myself, thanks!

@CISC CISC merged commit cc98f8d into ggml-org:master Nov 4, 2025
71 of 72 checks passed
@CISC
Copy link
Collaborator

CISC commented Nov 4, 2025

I don't think the backends check mode, so CIs will start failing once you add BICUBIC to the tests.

GittyBurstein pushed a commit to yael-works/llama.cpp that referenced this pull request Nov 5, 2025
gabe-l-hart added a commit to gabe-l-hart/llama.cpp that referenced this pull request Nov 5, 2025
* origin/master: (21 commits)
vulkan: Fix GGML_VULKAN_CHECK_RESULTS to better handle fusion (ggml-org#16919)
examples(gguf): GGUF example outputs (ggml-org#17025)
mtmd: allow QwenVL to process larger image by default (ggml-org#17020)
server : do not default to multiple slots with speculative decoding (ggml-org#17017)
mtmd: improve struct initialization (ggml-org#16981)
docs: Clarify the endpoint that webui uses (ggml-org#17001)
model : add openPangu-Embedded (ggml-org#16941)
ggml webgpu: minor set rows optimization (ggml-org#16810)
sync : ggml
ggml : fix conv2d_dw SVE path (ggml/1380)
CUDA: update ops.md (ggml-org#17005)
opencl: update doc (ggml-org#17011)
refactor: replace sprintf with snprintf for safer string handling in dump functions (ggml-org#16913)
vulkan: remove the need for the dryrun (ggml-org#16826)
server : do context shift only while generating (ggml-org#17000)
readme : update hot topics (ggml-org#17002)
ggml-cpu : bicubic interpolation (ggml-org#16891)
ci : apply model label to models (ggml-org#16994)
chore : fix models indent after refactor (ggml-org#16992)
Fix garbled output with REPACK at high thread counts (ggml-org#16956)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants